On Wed, 2014-10-15 at 23:10 +0200, Jerome Martin wrote: > > On 10/15/2014 10:28 PM, Rufe Glick wrote: > > On Wed, Oct 15, 2014 at 4:06 AM, Jerome Martin <jxm@xxxxxxxxxxx> wrote: > >> On 10/15/2014 03:02 AM, Andy Grover wrote: > >>> On 10/13/2014 08:37 PM, Rufe Glick wrote: > > >>>> [...] > > > So when generate_node_acls is set to 0, the cache_dynamic_acls setting > > has no effect by definition. When generate_node_acls is set to 1, the > > cache_dynamic_acls is set to 1 by the kernel anyway. So maybe you > > shouldn't expose that configuration parameter in the targetcli > > altogether? Or do you keep it there for compatibility reasons? Then > > you could at least mark it as obsolete in the man page and in the > > short description available in the targetcli by typing 'get attribute' > > + Enter in the TPG context. > > First, I want to point out that before hiding this attribute, I want to > double check with Nic and co that there is not a use-case that I have > missed for the iSCSI demo-mode that would require to manually tweak the > cache_dynamic_acls. > So as correctly described earlier in the thread by Jerome, forcing cached_dynamic_acls=1 in-kernel when generate_node_acls=1 is set ended up being the (best) default for demo-mode so that things 'just work' for typical user configurations, given that cached_dynamic_acls=1 is required in order to keep active PR metadata around during typical session (I_T nexus) resets. The reason that cached_dynamic_acls is still exposed as a TPG attribute is primarily for large public demo-mode setups (like boot.kernel.org was originally supposed to be :) where it's useful to release the dynamically allocated se_node_acl each time I_T nexus shutdown/timeout occurs, in order to avoid left-over se_node_acl memory with lots of transient initiators coming and going. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
