On Fri, 1 August 2014 07:56:30 -0700, Roland Dreier wrote: > On Thu, Jul 31, 2014 at 5:22 PM, Nicholas A. Bellinger > <nab@xxxxxxxxxxxxxxx> wrote: > > Roland + Joern, I'm specifically talking about the following patches: > > > > https://github.com/rolandd/qla-target/commit/77bd729e5e9f858495dfded7c08e548bc9ecc9be > > https://github.com/rolandd/qla-target/commit/79ae07a141950c0008480a46f91d72318a1d799e > > > > Can you please confirm if these are related to what deeepdish has > > reported here..? > > Our latest tree doesn't use the btree -> radix tree conversion -- we > decided there is nothing wrong with the btree code itself. So from > that POV upstream is fine. If memory serves, replacing the btree with a radix tree helped because the radix tree is more robust against races. With a btree the entries get moved left and right a lot and only rarely have NULL neighbors. At the end of the day, the conversion allowed us to survive in spite of other unfixed bugs a bit longer. We should go through the list of our patches soon. I would be amazed if there weren't some forgotten fixes we haven't sent to you yet. I will take the blame for that. Jörn -- The only good bug is a dead bug. -- Starship Troopers -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
