Hi nab, On 3/24/14, 5:39 PM, Alex Leung wrote: > On 3/24/14, 1:42 PM, Nicholas A. Bellinger wrote: > > <SNIP> > >> >> Mmmm, good catch. >> >> So calling ->aborted_task() from transport_cmd_finish_abort() makes >> sense to me, but of course only when the se_cmd descriptor is being >> released. >> >> Here's an updated incremental patch that I'll fold into the original for >> -v2. > > Thanks for the update. One quick typo fix below. > > -Alex > > diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c > index a4a5179..9393544 100644 > --- a/drivers/target/target_core_transport.c > +++ b/drivers/target/target_core_transport.c > @@ -610,7 +610,7 @@ void transport_cmd_finish_abort(struct se_cmd *cmd, int remove) > * releasing the descriptor via TFO->release_cmd() > */ > if (remove) > - se_cmd->se_tfo->aborted_task(cmd); > + cmd->se_tfo->aborted_task(cmd); > > if (transport_cmd_check_stop_to_fabric(cmd)) > return; > With your patch plus the above typo fix, my testing looks good. I was able to verify that the TFO->aborted_task call was received with both Abort Task and LUN Reset. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
