Hi Nicholas, On 3/22/14, 3:50 PM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > Now that TASK_ABORTED status is not generated for all cases by > TMR ABORT_TASK + LUN_RESET, a new TFO->abort_task() caller is > necessary in order to give fabric drivers a chance to unmap > hardware / software resources before the se_cmd descriptor is > released via the normal TFO->release_cmd() codepath. > > This patch adds TFO->aborted_task() in core_tmr_abort_task() > in place of the original transport_send_task_abort(), and > also updates all fabric drivers to implement this caller. > > The fabric drivers that include changes to perform cleanup > via ->aborted_task() are: > > - iscsi-target > - iser-target > - srpt > - tcm_qla2xxx > > The fabric drivers that currently set ->aborted_task() to > NOPs are: > > - loopback > - tcm_fc > - usb-gadget > - sbp-target > - vhost-scsi > > For the latter five, there appears to be no additional cleanup > required before invoking TFO->release_cmd() to release the > se_cmd descriptor. > Shouldn't this also be called for the LUN Reset path? i.e. core_tmr_lun_reset --> core_tmr_drain_state_list() --> core_tmr_handle_tas_abort(). Or better yet, just once from transport_cmd_finish_abort()? Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
