On Thu, 2014-02-20 at 19:31 +0200, Sagi Grimberg wrote: > Found by Dan Carpenter smatch run. > > drivers/target/target_core_sbc.c:585 sbc_set_prot_op_checks() warn: missing > break? reassigning 'cmd->prot_checks' > > Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx> > --- > drivers/target/target_core_sbc.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c > index 59fdc9f..edda77f 100644 > --- a/drivers/target/target_core_sbc.c > +++ b/drivers/target/target_core_sbc.c > @@ -580,6 +580,7 @@ sbc_set_prot_op_checks(u8 protect, enum target_prot_type prot_type, > case 0x0: > case 0x3: > cmd->prot_checks = 0; > + break; > case 0x1: > case 0x5: > cmd->prot_checks = TARGET_DIF_CHECK_GUARD; Applied + squashed into target-pending/rdma-dif for commit: Target/sbc: Set protection operation and relevant checks --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
