Re: [PATCH] IB/isert: Fix failed sector assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2014-02-20 at 20:16 +0200, Sagi Grimberg wrote:
> RDMA verbs report failed offset of input space,
> the correct computation is:
> 	sector = offset / (sector_size + 8)
> 
> Signed-off-by: Sagi Grimberg <sagig@xxxxxxxxxxxx>
> ---
>  drivers/infiniband/ulp/isert/ib_isert.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index ba6791d..3def22b 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
> @@ -1677,7 +1677,7 @@ isert_completion_rdma_write(struct iser_tx_desc *tx_desc,
>  			goto fail_mr_status;
>  		}
>  		if (mr_status.fail_status & IB_MR_CHECK_SIG_STATUS) {
> -			u32 block_size = se_cmd->se_dev->dev_attrib.block_size;
> +			u32 block_size = se_cmd->se_dev->dev_attrib.block_size + 8;
>  
>  			switch (mr_status.sig_err.err_type) {
>  			case IB_SIG_BAD_GUARD:

AFAICT, this needs to be fixed in both isert_completion_rdma_write() and
isert_completion_rdma_read(), right..?

Applying + squashing with this extra bit into target-pending/rdma-dif
for commit:

   IB/isert: Support T10-PI protected transactions

Thanks!

--nab

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux