Hi Dan,
On Thu, 2014-01-30 at 14:23 +0300, Dan Carpenter wrote:
> Hello Andy Grover,
>
> The patch 9037c8332432: "target/iscsi: Fix network portal creation
> race" from Jan 24, 2014, leads to the following static checker
> warning:
>
> drivers/target/iscsi/iscsi_target.c:341 iscsit_get_np()
> warn: 'bottom_half:' is sometimes locked here and sometimes unlocked.
>
> drivers/target/iscsi/iscsi_target.c
> 313 static struct iscsi_np *iscsit_get_np(
> 314 struct __kernel_sockaddr_storage *sockaddr,
> 315 int network_transport)
> 316 {
> 317 struct iscsi_np *np;
> 318 bool match;
> 319
> 320 list_for_each_entry(np, &g_np_list, np_list) {
> 321 spin_lock_bh(&np->np_thread_lock);
> 322 if (np->np_thread_state != ISCSI_NP_THREAD_ACTIVE) {
> 323 spin_unlock(&np->np_thread_lock);
> ^^^^^^^^^^^
> This should be spin_unlock_bh().
Fixed, and included into the original commit.
Thanks!
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
