Hello Andy Grover,
The patch 9037c8332432: "target/iscsi: Fix network portal creation
race" from Jan 24, 2014, leads to the following static checker
warning:
drivers/target/iscsi/iscsi_target.c:341 iscsit_get_np()
warn: 'bottom_half:' is sometimes locked here and sometimes unlocked.
drivers/target/iscsi/iscsi_target.c
313 static struct iscsi_np *iscsit_get_np(
314 struct __kernel_sockaddr_storage *sockaddr,
315 int network_transport)
316 {
317 struct iscsi_np *np;
318 bool match;
319
320 list_for_each_entry(np, &g_np_list, np_list) {
321 spin_lock_bh(&np->np_thread_lock);
322 if (np->np_thread_state != ISCSI_NP_THREAD_ACTIVE) {
323 spin_unlock(&np->np_thread_lock);
^^^^^^^^^^^
This should be spin_unlock_bh().
324 continue;
325 }
326
327 match = iscsit_check_np_match(sockaddr, np, network_transport);
328 if (match == true) {
329 /*
330 * Increment the np_exports reference count now to
331 * prevent iscsit_del_np() below from being called
332 * while iscsi_tpg_add_network_portal() is called.
333 */
334 np->np_exports++;
335 spin_unlock_bh(&np->np_thread_lock);
336 return np;
337 }
338 spin_unlock_bh(&np->np_thread_lock);
339 }
340
341 return NULL;
342 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
