Re: [PATCH] target/file: Update hw_max_sectors based on current block_size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 12, 2013 at 08:38:47PM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> 
> This patch allows FILEIO to update hw_max_sectors based on the current
> block_size.  This is required because vfs_[writev,readv]() can accept
> a maximum of 2048 iovecs per call, so the enforced hw_max_sectors really
> needs to be calculated based on block_size.
> 
> This addresses a >= v3.5 bug where block_size=512 was rejecting > 1M
> sized I/O requests, because FD_MAX_SECTORS was hardcoded to 2048 for
> the block_size=4096 case.

The whole setup seems stupid here.  What's the point of another method
during config time if there are enough already?

And why is the max I/O size specified in sectors anyway, and not counted
in bytes?

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux