On Tue, 2013-10-08 at 21:58 +0200, Thomas Glanzmann wrote:
> Hello Nab,
>
> > Please confirm that
> > iqn.2013-03.de.campusvl.v102.storage:shared-01.v102.campusvl.de is
> > configured with generate_node_acls=0, and that no active sessions from
> > the initiator has created a NodeACL with se_node_acl->dynamic_node_acl
>
> I missed the 'generate_node_acls=0' part. When I turn that one of, I do
> not discover the public LUNs on the portal itself and the discovery
> returns nothing:
>
> (miniwheezy64) [~] iscsiadm -m discovery -t sendtargets -p 10.101.99.4
> iscsiadm: No portals found
>
>
> I'm trying do discover the demo LUNs thata re on that portal but not the ones
> which are on the portal in the different subnet.
>
Ok, I'm now getting more confused as to what your trying to accomplish
with these patches.
The original discussion was to restrict SendTargets discovery
information for specific TargetName+TargetPortalGroupTag endpoints,
based upon how the endpoint was configured using TPG attributes.
Thus far it has included the following criteria:
- If demo-mode (generate_node_acls=1) is enabled on the TargetName+TargetPortalGroup
endpoint, always return TargetName regardless of other settings
- If demo-mode (generate_node_acls=0) is disabled, only return TargetName if NodeACL
exists that matches the InitiatorName for the discovery session.
So from what I can tell the changes in your PATCH-v3 achieve these
points.
Where I'm getting confused is where portals and subnets are now involved
in the discussion. The above criteria will not restrict SendTargets
discovery based on which portal the initiator is connecting to, but only
restricts SendTargets discovery based upon how each of the endpoints are
configured.
Eg: The initiator will always see the same restricted set of SendTargets
discovery information based on the above criteria, regardless of which
network portal it's actually connecting to.
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
