On Tue, 2013-10-08 at 09:47 -0700, Roland Dreier wrote: > From: Roland Dreier <roland@xxxxxxxxxxxxxxx> > > The unpacked_lun field in the SCSI target tracepoints should be > initialized with cmd->orig_fe_lun rather than cmd->se_lun->unpacked_lun > for two reasons: > > - most importantly, if we are in the cmd_complete tracepoint > returning a check condition due to no LUN found, cmd->se_lun will > be NULL and we'll crash trying to dereference it. > > - also, in any case, cmd->se_lun->unpacked_lun is an internal index > into the target's internal set of LUNs; cmd->orig_fe_lun is much > more useful and interesting, since it's the value the initiator > actually sent. > > Signed-off-by: Roland Dreier <roland@xxxxxxxxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> # 3.11+ > --- > include/trace/events/target.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, and queuing up for the next v3.12-rc fixes PULL. Thanks Roland! --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
