On Wed, 2013-04-03 at 08:14 +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git iser-target-wip
> head: 9614b2516bed2416f9c2748675935179ab767fcc
> commit: 9614b2516bed2416f9c2748675935179ab767fcc [17/17] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver
> config: make ARCH=i386 allyesconfig
>
> All warnings:
>
> drivers/infiniband/ulp/isert/ib_isert.c:943:2: warning: #warning FIXME: Unexpected unsolicited_data out [-Wcpp]
> drivers/infiniband/ulp/isert/ib_isert.c:957:2: warning: #warning FIXME: Non page-aligned unsolicited_data out [-Wcpp]
> drivers/infiniband/ulp/isert/ib_isert.c: In function 'isert_rx_completion':
> >> drivers/infiniband/ulp/isert/ib_isert.c:1108:179: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat]
Fixed.
> drivers/infiniband/ulp/isert/ib_isert.c: In function 'isert_init':
> >> drivers/infiniband/ulp/isert/ib_isert.c:2221:91: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Wformat]
> >> drivers/infiniband/ulp/isert/ib_isert.c:2223:96: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Wformat]
> >> drivers/infiniband/ulp/isert/ib_isert.c:2224:152: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Wformat]
Dropping this old debug code.
> drivers/infiniband/ulp/isert/ib_isert.c: In function 'isert_connect_request':
> >> drivers/infiniband/ulp/isert/ib_isert.c:286:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
> drivers/infiniband/ulp/isert/ib_isert.c:148:6: note: 'ret' was declared here
Fixed.
> drivers/infiniband/ulp/isert/ib_isert.c:425 isert_connect_release() warn: variable dereferenced before check 'isert_conn->conn_cm_id' (see line 408)
>
Dropping the unnecessary (isert_conn->conn_cm_id != NULL) check here
triggering this warning.
Thanks Fengguang!
--nab
> vim +1108 drivers/infiniband/ulp/isert/ib_isert.c
>
> 1092
> 1093 if ((char *)desc == isert_conn->login_req_buf) {
> 1094 rx_dma = isert_conn->login_req_dma;
> 1095 rx_buflen = ISER_RX_LOGIN_SIZE;
> 1096 pr_debug("ISER login_buf: Using rx_dma: 0x%llx, rx_buflen: %d\n",
> 1097 rx_dma, rx_buflen);
> 1098 } else {
> 1099 rx_dma = desc->dma_addr;
> 1100 rx_buflen = ISER_RX_PAYLOAD_SIZE;
> 1101 pr_debug("ISER req_buf: Using rx_dma: 0x%llx, rx_buflen: %d\n",
> 1102 rx_dma, rx_buflen);
> 1103 }
> 1104
> 1105 ib_dma_sync_single_for_cpu(ib_dev, rx_dma, rx_buflen, DMA_FROM_DEVICE);
> 1106
> 1107 hdr = &desc->iscsi_header;
> > 1108 pr_debug("iSCSI opcode: 0x%02x, ITT: 0x%08x, flags: 0x%02x dlen: %lu\n",
> 1109 hdr->opcode, hdr->itt, hdr->flags,
> 1110 (int)xfer_len - ISER_HEADERS_LEN);
> 1111
> 1112 if ((char *)desc == isert_conn->login_req_buf)
> 1113 isert_rx_login_req(rx_desc, xfer_len - ISER_HEADERS_LEN,
> 1114 isert_conn);
> 1115 else
> 1116 isert_rx_do_work(rx_desc, isert_conn);
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
