Re: [target:iser-target-wip 17/17] drivers/infiniband/ulp/isert/ib_isert.c:943:2: warning: #warning FIXME: Unexpected unsolicited_data out

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-04-03 at 07:53 +0800, kbuild test robot wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git iser-target-wip
> head:   9614b2516bed2416f9c2748675935179ab767fcc
> commit: 9614b2516bed2416f9c2748675935179ab767fcc [17/17] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver
> config: make ARCH=powerpc allmodconfig
> 
> All warnings:
> 
>    drivers/infiniband/ulp/isert/ib_isert.c: In function 'isert_handle_iscsi_dataout':
> >> drivers/infiniband/ulp/isert/ib_isert.c:943:2: warning: #warning FIXME: Unexpected unsolicited_data out [-Wcpp]
> >> drivers/infiniband/ulp/isert/ib_isert.c:957:2: warning: #warning FIXME: Non page-aligned unsolicited_data out [-Wcpp]
>    drivers/infiniband/ulp/isert/ib_isert.c: In function 'isert_create_device_ib_res':
>    drivers/infiniband/ulp/isert/ib_isert.c:148:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
> 

Fixing up this warning from earlier in isert_create_device_ib_res() with
powerpc allmodconfig.

Thanks Fengguang!

--nab

> vim +943 drivers/infiniband/ulp/isert/ib_isert.c
> 
>    937		rc = iscsit_check_dataout_hdr(conn, buf, &cmd);
>    938		if (rc < 0)
>    939			return rc;
>    940		else if (!cmd)
>    941			return 0;
>    942	
>  > 943	#warning FIXME: Unexpected unsolicited_data out
>    944		if (!cmd->unsolicited_data) {
>    945			pr_err("Received unexpected solicited data payload\n");
>    946			dump_stack();
>    947			return -1;
>    948		}
>    949	
>    950		pr_debug("Unsolicited DataOut unsol_data_len: %u, write_data_done: %u, data_length: %u\n",
>    951			 unsol_data_len, cmd->write_data_done, cmd->se_cmd.data_length);
>    952	
>    953		sg_off = cmd->write_data_done / PAGE_SIZE;
>    954		sg_start = &cmd->se_cmd.t_data_sg[sg_off];
>    955		sg_nents = max(1UL, DIV_ROUND_UP(unsol_data_len, PAGE_SIZE));
>    956		page_off = cmd->write_data_done % PAGE_SIZE;
>  > 957	#warning FIXME: Non page-aligned unsolicited_data out
>    958		if (page_off) {
>    959			pr_err("Received unexpected non-page aligned data payload\n");
>    960			dump_stack();
> 
> ---
> 0-DAY kernel build testing backend              Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation


--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux