On Wed, 2012-08-01 at 14:51 -0700, Mark Rustad wrote:
> Stop doing a pile of work related to debugging messages when
> the ft_debug_logging flag is not set. Use unlikely to add the
> check in a way that the check can be inlined without inlining the
> whole thing.
>
> Signed-off-by: Mark Rustad <mark.d.rustad@xxxxxxxxx>
> ---
>
Thanks MDR, looks fine. Applying this to queue for now, and will make
sure it's included in the post -rc1 3.6-rc-fixes PULL.
Thank you!
--nab
> drivers/target/tcm_fc/tcm_fc.h | 1 +
> drivers/target/tcm_fc/tfc_cmd.c | 8 +++++++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/target/tcm_fc/tcm_fc.h b/drivers/target/tcm_fc/tcm_fc.h
> index c5eb3c3..eea6935 100644
> --- a/drivers/target/tcm_fc/tcm_fc.h
> +++ b/drivers/target/tcm_fc/tcm_fc.h
> @@ -131,6 +131,7 @@ extern struct list_head ft_lport_list;
> extern struct mutex ft_lport_lock;
> extern struct fc4_prov ft_prov;
> extern struct target_fabric_configfs *ft_configfs;
> +extern unsigned int ft_debug_logging;
>
> /*
> * Fabric methods.
> diff --git a/drivers/target/tcm_fc/tfc_cmd.c b/drivers/target/tcm_fc/tfc_cmd.c
> index 5b65f33..5f2f169 100644
> --- a/drivers/target/tcm_fc/tfc_cmd.c
> +++ b/drivers/target/tcm_fc/tfc_cmd.c
> @@ -48,7 +48,7 @@
> /*
> * Dump cmd state for debugging.
> */
> -void ft_dump_cmd(struct ft_cmd *cmd, const char *caller)
> +static void _ft_dump_cmd(struct ft_cmd *cmd, const char *caller)
> {
> struct fc_exch *ep;
> struct fc_seq *sp;
> @@ -80,6 +80,12 @@ void ft_dump_cmd(struct ft_cmd *cmd, const char *caller)
> }
> }
>
> +void ft_dump_cmd(struct ft_cmd *cmd, const char *caller)
> +{
> + if (unlikely(ft_debug_logging))
> + _ft_dump_cmd(cmd, caller);
> +}
> +
> static void ft_free_cmd(struct ft_cmd *cmd)
> {
> struct fc_frame *fp;
>
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
