On 07/10/2012 11:43 PM, Christoph Hellwig wrote: > On Tue, Jul 10, 2012 at 05:03:07PM -0700, Andy Grover wrote: >> On 07/09/2012 11:00 PM, Christoph Hellwig wrote: >>> On Mon, Jul 09, 2012 at 11:46:08AM -0700, Andy Grover wrote: >>>> It looks like it only wants to allow the use of TYPE_DISK block devices >>>> for iblock. Is there another way from userspace to know if a block >>>> device is a disk vs. tape or optical? >>> >>> iblock should not care - it just submits bios. And pscsci already does >>> it's own internal checks. >> >> I am doubtful iblock works with non-disk block devices. It assumes >> TYPE_DISK. > > Where exactly? > target_core_iblock.c:686 iblock_get_device_type returns TYPE_DISK also target_core_iblock.c iblock_parse_cdb calls sbc_parse_cdb, which doesn't support MMC cmds. also the fact we started with, that rtslib is working hard to make sure only TYPE_DISK block devices are allowed for iblock. -- Andy -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
