On 07/09/2012 11:00 PM, Christoph Hellwig wrote: > On Mon, Jul 09, 2012 at 11:46:08AM -0700, Andy Grover wrote: >> It looks like it only wants to allow the use of TYPE_DISK block devices >> for iblock. Is there another way from userspace to know if a block >> device is a disk vs. tape or optical? > > iblock should not care - it just submits bios. And pscsci already does > it's own internal checks. I am doubtful iblock works with non-disk block devices. It assumes TYPE_DISK. We should try to warn people when defining a backstore, not errors to dmesg when they actually try to use it. The major number check may be ugly and/or wrong, but if there are no alternatives for how we can guide people to prefer pscsi over iblock for non-disk scsi devices, isn't it better than nothing? Regards -- Andy -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
