On Fri, 2012-05-11 at 10:33 -0400, Jörn Engel wrote:
> The function is effectively void and doesn't need any goto logic.
>
> Signed-off-by: Joern Engel <joern@xxxxxxxxx>
> ---
> drivers/target/target_core_transport.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index ce91d59..60a893f 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1970,7 +1970,7 @@ static inline int transport_execute_task_attr(struct se_cmd *cmd)
> * Called from fabric module context in transport_generic_new_cmd() and
> * transport_generic_process_write()
> */
> -static int transport_execute_tasks(struct se_cmd *cmd)
> +static void transport_execute_tasks(struct se_cmd *cmd)
> {
> int add_tasks;
> struct se_device *se_dev = cmd->se_dev;
> @@ -1984,16 +1984,12 @@ static int transport_execute_tasks(struct se_cmd *cmd)
> * attribute for the tasks of the received struct se_cmd CDB
> */
> add_tasks = transport_execute_task_attr(cmd);
> - if (!add_tasks)
> - goto execute_tasks;
> -
> - __transport_execute_tasks(se_dev, cmd);
> - return 0;
> + if (add_tasks) {
> + __transport_execute_tasks(se_dev, cmd);
> + return;
> + }
> }
> -
> -execute_tasks:
> __transport_execute_tasks(se_dev, NULL);
> - return 0;
> }
>
> static int __transport_execute_tasks(struct se_device *dev, struct se_cmd *new_cmd)
Applied, and including into for-next.
Thanks Joern!
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
