Hello Nick! In target_emulate_request_sense, we set err to -EINVAL only to ignore the value and return 0 from the function. The mindless mechanical part of my brain would like to just remove the err variable, but somehwo I cannot convince myself that we really should be ignoring it. Do you remember the background of that code and what it intended to do? Jörn -- The rabbit runs faster than the fox, because the rabbit is running for his life while the fox is only running for his dinner. -- Aesop -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html