On Thu, 2011-12-01 at 04:18 -0500, Christoph Hellwig wrote: > On Thu, Dec 01, 2011 at 06:26:37AM +0000, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > > > This patch removes the original usage of __transport_execute_tasks() ahead > > of every transport_get_cmd_from_queue() call in transport_processing_thread(). > > This helps reduce se_device->execute_task_lock contention between qla2xxx wq > > with target_submit_cmd() for READs and transport_processing_thread() > > context servicing WRITEs with full payloads for I/O submission. > > > > It also adds a __transport_execute_tasks() to kick the task queue again > > without a *se_cmd descriptor with existing queue full logic, but this may > > end up not being necessary. > > Please figure out if it is nessecary, and if not don't add it. > That code needs a major overhaul, and adding just in case code to it > is only making it more complicated without a reason. > Yes. Removing this extra usage from the series after testing with queue-full handling (and other fabrics) is on my TODO. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
