Re: [PATCH 2/3] target: Remove __transport_execute_tasks() for each processing context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 01, 2011 at 06:26:37AM +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> 
> This patch removes the original usage of __transport_execute_tasks() ahead
> of every transport_get_cmd_from_queue() call in transport_processing_thread().
> This helps reduce se_device->execute_task_lock contention between qla2xxx wq
> with target_submit_cmd() for READs and transport_processing_thread()
> context servicing WRITEs with full payloads for I/O submission.
> 
> It also adds a __transport_execute_tasks() to kick the task queue again
> without a *se_cmd descriptor with existing queue full logic, but this may
> end up not being necessary.

Please figure out if it is nessecary, and if not don't add it.
That code needs a major overhaul, and adding just in case code to it
is only making it more complicated without a reason.

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux