On Mon, 2011-11-28 at 13:57 +0100, Sebastian Andrzej Siewior wrote:
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> drivers/target/target_core_configfs.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index fab9260..c1a263c 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -1711,6 +1711,9 @@ static ssize_t target_core_store_dev_alias(
> read_bytes = snprintf(&se_dev->se_dev_alias[0], SE_DEV_ALIAS_LEN,
> "%s", page);
>
> + if (se_dev->se_dev_alias[read_bytes - 1] == '\n')
> + se_dev->se_dev_alias[read_bytes - 1] = '\0';
> +
> pr_debug("Target_Core_ConfigFS: %s/%s set alias: %s\n",
> config_item_name(&hba->hba_group.cg_item),
> config_item_name(&se_dev->se_dev_group.cg_item),
> @@ -1757,6 +1760,9 @@ static ssize_t target_core_store_dev_udev_path(
> read_bytes = snprintf(&se_dev->se_dev_udev_path[0], SE_UDEV_PATH_LEN,
> "%s", page);
>
> + if (se_dev->se_dev_udev_path[read_bytes - 1] == '\n')
> + se_dev->se_dev_udev_path[read_bytes - 1] = '\0';
> +
> pr_debug("Target_Core_ConfigFS: %s/%s set udev_path: %s\n",
> config_item_name(&hba->hba_group.cg_item),
> config_item_name(&se_dev->se_dev_group.cg_item),
OK, I think this is reasonable for direct configfs usage, and does not
effect existing userspace code. Applied to lio-core.
Thanks,
--nab
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
