On Mon, 2011-11-28 at 16:01 +0100, Stefan Bergstrand wrote: > Hi, > > I just tried your script for generating a "tcm_nab5000" module on > kernel 3.1.2. For me, it does not turn out as in the > tcm_mod_builder.txt file... > > Perhaps something has changed in the kernel since you wrote the > instructions/code? > > > First, module source generation (works as expected): > > root@storagec1n1:~/linux-3.1.2/Documentation/target# python > tcm_mod_builder.py -p iSCSI -m tcm_nab5000 > tcm_dir: /root/linux-3.1.2/Documentation/target/../../ > Set fabric_mod_name: tcm_nab5000 > Set > fabric_mod_dir: /root/linux-3.1.2/Documentation/target/../../drivers/target/tcm_nab5000 > Using proto_ident: iSCSI > Creating > fabric_mod_dir: /root/linux-3.1.2/Documentation/target/../../drivers/target/tcm_nab5000 > Writing > file: /root/linux-3.1.2/Documentation/target/../../drivers/target/tcm_nab5000/tcm_nab5000_base.h > Using > tcm_mod_scan_fabric_ops: /root/linux-3.1.2/Documentation/target/../../include/target/target_core_fabric_ops.h > Writing > file: /root/linux-3.1.2/Documentation/target/../../drivers/target/tcm_nab5000/tcm_nab5000_fabric.c > Writing > file: /root/linux-3.1.2/Documentation/target/../../drivers/target/tcm_nab5000/tcm_nab5000_fabric.h > Writing > file: /root/linux-3.1.2/Documentation/target/../../drivers/target/tcm_nab5000/tcm_nab5000_configfs.c > Writing > file: /root/linux-3.1.2/Documentation/target/../../drivers/target/tcm_nab5000/Makefile > Writing > file: /root/linux-3.1.2/Documentation/target/../../drivers/target/tcm_nab5000/Kconfig > Would you like to add tcm_nab5000to drivers/target/Makefile..? > [yes,no]: yes > Would you like to add tcm_nab5000to drivers/target/Kconfig..? > [yes,no]: yes > > > I do "make menuconfig" and add the tvm_nab5000 module. > > After that, doing "make modules" fails with: > > > root@storagec1n1:~/linux-3.1.2# make modules > scripts/kconfig/conf --silentoldconfig Kconfig > CHK include/linux/version.h > CHK include/generated/utsrelease.h > CALL scripts/checksyscalls.sh > CC [M] drivers/target/tcm_nab5000/tcm_nab5000_fabric.o > CC [M] drivers/target/tcm_nab5000/tcm_nab5000_configfs.o > drivers/target/tcm_nab5000/tcm_nab5000_configfs.c:177: error: unknown > field ‘release_cmd_to_pool’ specified in initializer > drivers/target/tcm_nab5000/tcm_nab5000_configfs.c:177: error: > ‘tcm_nab5000_release_cmd’ undeclared here (not in a function) > drivers/target/tcm_nab5000/tcm_nab5000_configfs.c:178: error: unknown > field ‘release_cmd_direct’ specified in initializer > drivers/target/tcm_nab5000/tcm_nab5000_configfs.c:191: error: unknown > field ‘new_cmd_failure’ specified in initializer > drivers/target/tcm_nab5000/tcm_nab5000_configfs.c:191: error: > ‘tcm_nab5000_new_cmd_failure’ undeclared here (not in a function) > drivers/target/tcm_nab5000/tcm_nab5000_configfs.c:198: error: unknown > field ‘pack_lun’ specified in initializer > drivers/target/tcm_nab5000/tcm_nab5000_configfs.c:198: error: > ‘tcm_nab5000_pack_lun’ undeclared here (not in a function) > make[3]: *** [drivers/target/tcm_nab5000/tcm_nab5000_configfs.o] Fel 1 > make[2]: *** [drivers/target/tcm_nab5000] Fel 2 > make[1]: *** [drivers/target] Fel 2 > make: *** [drivers] Fel 2 > > Hi Stefan, The tcm_mod_builder.py skeleton output build breakage has been fixed in lio-core.git. However from your log the script in mainline is a little more out of sync for what's in include/target/target_core_fabric_ops.h. I'll look at getting this fixed up soon along with other target-pending v3.2-rc items now in lio-core. Thanks for testing tcm_mod_builder.py! --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
