On Mon, 28 November 2011 10:11:55 +0100, Sebastian Andrzej Siewior wrote: > On 11/26/2011 07:28 PM, Jörn Engel wrote: > >> Also please notice the missing ">> PAGE_SHIFT" when assigning >> req->rd_page in your patch. > > Why missing? I used do_div() for that. You are right. Gah! How I hate that macro. Regular functions either leave their parameters unchanged, or take pointer arguments, making the side-effect rather obvious to the reader. 2:1 for you, I guess. ;) Jörn -- Homo Sapiens is a goal, not a description. -- unknown -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
