On 11/26/2011 07:28 PM, Jörn Engel wrote:
I could change tmp to byte_offset if you want. However your& probably
does not compile on 32bit. And for that reason we have do_div() :)
Are you saying that you cannot mask 64bit value on 32bit machines? Or
shift? Even if that were true, which I doubt very much, the answer
would be to create something like do_div() for masks and shifts, and
explicitly not use 64bit divisions on a 32bit cpu.
Sorry, I mixed up internally % with &. Your shift and mask should be
just fine.
Also please notice the missing ">> PAGE_SHIFT" when assigning
req->rd_page in your patch.
Why missing? I used do_div() for that.
Jörn
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
