On Mon, 2011-11-28 at 05:15 -0500, Christoph Hellwig wrote: > On Mon, Nov 28, 2011 at 01:53:56AM -0800, Nicholas A. Bellinger wrote: > > > Can't the check_release flags in struct se_cmd go away as well now? > > > > > > > Almost.. This is still required for loopback and iscsi-target, but once > > these are converted to target_submit_cmd() or something similar > > (iscsi-target still has the special immediate data cases), this can be > > dropped. > > In the current tree only target_get_sess_cmd ever sets > cmd->check_release, and that only gets called from qla2xxx and ib_srpt. > In qla_tgt-3.3 code, it's to avoid the new call to target_put_sess_cmd() in transport_release_cmd() -> transport_generic_free_cmd() when perform the final put for fabrics who are still not using se_sess kref. This is not the case in master however, which is what I think you're looking at, right..? -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
