Re: [PATCH 2/3] target: introduce and use pr_debugc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-11-28 at 10:15 +0100, Sebastian Andrzej Siewior wrote:
> On 11/28/2011 09:01 AM, Nicholas A. Bellinger wrote:
> > Hi Sebastian,
> 
> Hi Nicholas,
> 
> > Thanks for fixing this up in scsi_dump_inquiry() usage.  I've split this
> > up into two separate patches for adding pr_debugc() into printk.h and
> > changing in target-core, and will queue this via target-pending for v3.3
> > with akpm CC'ed.
> 
> Please note that I broke the dynamic printk because I did not add
> anything there. An alternative would be to add 20byte long char array
> on the stick and first move the characters there and then use one
> pr_debug() for it.
> 

Hmmmm, sorry just noticed that..

In that case we might want to think if it's possible to pass KERN_CONT
here instead if duplicating another dynamic_pr_debug().  Using local
stack is fine with me, but perhaps we should see what akpm would like
here.

Thanks,

--nab


--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux