On Mon, 2011-11-28 at 03:15 -0500, Christoph Hellwig wrote: > On Mon, Nov 28, 2011 at 09:10:09AM +0100, J??rn Engel wrote: > > On Mon, 28 November 2011 03:07:00 -0500, Christoph Hellwig wrote: > > > > > > Why don't you simply do the kref_get after target_get_sess_cmd has > > > returned, avoiding the parameter to target_get_sess_cmd? > > > > > > > + int rc, flags = (bidi) ? TARGET_SCF_BIDI_OP : 0 | TARGET_SCF_ACK_KREF; > > > > > > no need for the braces around bidi. > > > > And isn't "0 | TARGET_SCF_ACK_KREF" the same as "TARGET_SCF_ACK_KREF"? > > It is - but that's not what was indeded. > > So the whole think should be: > > flags = (bidi ? TARGET_SCF_BIDI_OP : 0) | TARGET_SCF_ACK_KREF; > > or even better: > > flags = TARGET_SCF_ACK_KREF; > if (bidi) > flags |= TARGET_SCF_BIDI_OP; > Duh, thanks for catching that.. Fixing in qla_tgt-3.3 now. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
