On Mon, 28 November 2011 03:07:00 -0500, Christoph Hellwig wrote: > > Why don't you simply do the kref_get after target_get_sess_cmd has > returned, avoiding the parameter to target_get_sess_cmd? > > > + int rc, flags = (bidi) ? TARGET_SCF_BIDI_OP : 0 | TARGET_SCF_ACK_KREF; > > no need for the braces around bidi. And isn't "0 | TARGET_SCF_ACK_KREF" the same as "TARGET_SCF_ACK_KREF"? Jörn -- Functionality is an asset, but code is a liability. --Ted Dziuba -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
