On Fri, 2011-11-25 at 15:46 +0100, Sebastian Andrzej Siewior wrote: > On 11/24/2011 08:57 PM, Fubo Chen wrote: > > On Wed, Nov 23, 2011 at 8:53 PM, Sebastian Andrzej Siewior > > <bigeasy@xxxxxxxxxxxxx> wrote: > >> The code uses pr_debug macro which requires the DEBUG define in order to > >> do things. I can't find any evidence that it is defined somewhere so > >> here is a global switch for it. > >> > >> +ccflags-$(CONFIG_TARGET_DEBUG) += -DDEBUG > > > > You do not like DYNAMIC_DEBUG ? > > Wasn't thinking about it. So the next patch broke dynamic debug then. > Let me wait what Nicholas says once he gets back from turkey day. > Hello Sebastian, Your patch can be useful for out-of-tree testing purposes, but AFAICT we still want people to enable CONFIG_DYNAMIC_DEBUG=y and use debugfs for mainline debugging purposes. :) --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
