On Sun, 2011-11-20 at 16:29 -0500, Christoph Hellwig wrote: > On Fri, Nov 18, 2011 at 08:29:34PM +0000, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > > > This patch adds proper qla_tgt_sess->sess_kref operation for > > qla_tgt_sess reference and two flavours of qla_tgt_unreg_sess() > > in order to have a qla_hw_data->hardware_lock lock-less method > > to execute qla_tgt_cmd in qla_tgt_do_work() process context. > > > > It also convert existing ->hardware_lock held qla_tgt_sess_put() > > callers to use __qla_tgt_sess_put() > > Is there any good reason why we would ever actually want the hardware > lock held over call to __qla_tgt_sess_put? From a quick review most > places either acquire it just before or drop it just after later. > > Cleaning that part up will make locking in the driver a lot simpler. > Mmmmm.. > Nevermind that the whole session linkage should really move to a > different lock ASAP anyway. I think doing this makes sense now.. I'm still finishing up a few other qla_tgt-3.3 related items atm, but will look at getting this separated out over the next days. Thanks Christoph! -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
