> -static void ibmvscsis_check_stop_free(struct se_cmd *se_cmd)
> +static int ibmvscsis_check_stop_free(struct se_cmd *se_cmd)
> {
> if (se_cmd->se_tmr_req)
> - return;
> + return 0;
> transport_generic_free_cmd(se_cmd, 0);
> + return 1;
The code would be a lot cleaner if the core did the
transport_generic_free_cmd on a 1 return, although it's probably
fine to do that as a second stop.
Also using a bool type for a boolean return value makes the intent
more clear.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
