> @@ -1821,17 +1821,16 @@ attach: > int cmdsn_ret = iscsit_sequence_cmd(conn, cmd, hdr->cmdsn); > if (cmdsn_ret == CMDSN_HIGHER_THAN_EXP) > out_of_order_cmdsn = 1; > - else if (cmdsn_ret == CMDSN_LOWER_THAN_EXP) { > + else if (cmdsn_ret == CMDSN_LOWER_THAN_EXP) > return 0; > - } else { /* (cmdsn_ret == CMDSN_ERROR_CANNOT_RECOVER) */ > + else if (cmdsn_ret == CMDSN_ERROR_CANNOT_RECOVER) > return iscsit_add_reject_from_cmd( > ISCSI_REASON_PROTOCOL_ERROR, > 1, 0, buf, cmd); > - } > } minor nipick: this would be a bit more readable using a switch statement. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html