Andy, Sorry for my delayed response. More below. Cheers, Madhu On Sun, 2011-10-23 at 14:15 -0700, Andy Grover wrote: > On 10/23/2011 11:01 AM, Madhuranath N Iyengar wrote: > > From: Madhuranath Iyengar <mni@xxxxxxxxxxxxxxx> > > > > Folks, > > > > This patch series contains patches to address the following, towards > > reducing the lines of code a bit, and also improving readability: > > > > - Add a generic IOCB struct. This is to help with the patches that > > follow. > > - Remove unions within a a few structs, towards merging some fields > > within those structs. > > You should be driving casts in the driver to zero, not adding them. > Unions are ok. > I have no preference one way or the other. I made the change, because Roland in this email list had suggested that we remove the union and use a raw_iocb. I decided to change according to what Roland requested and also tried to do the same for other cases. My bad or maybe I misunderstood his request. I'll leave it to NAB to either pull in these patches or ignore them. > > - Shorten IOCB struct names, by removing "entry" in the names. > > All the typedefs in qla_target.h should be removed, too. > Again I do understand this is an issue, as typedefs raises a warning flag on running checkpatch.pl. CH had also raised a warning earlier. I have it in my TODO list. QLogic in qla_def.h have traditionally used typedefs for their IOCB and other structs, so I decided to not change the convention. I am in fact waiting for them to give the green on it on not using typedefs on newer IOCB structs (such as the ones in qla_target.h). > Regards -- Andy -- -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
