Re: [PATCH 0/6] qla2xxx/tcm_qla2xxx: More merging and renaming.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/23/2011 11:01 AM, Madhuranath N Iyengar wrote:
> From: Madhuranath Iyengar <mni@xxxxxxxxxxxxxxx>
> 
> Folks,
> 
> This patch series contains patches to address the following, towards
> reducing the lines of code a bit, and also improving readability:
> 
> - Add a generic IOCB struct. This is to help with the patches that
>   follow.
> - Remove unions within a a few structs, towards merging some fields
>   within those structs.

You should be driving casts in the driver to zero, not adding them.
Unions are ok.

> - Shorten IOCB struct names, by removing "entry" in the names. 

All the typedefs in qla_target.h should be removed, too.

Regards -- Andy
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux