On Tue, 2011-09-27 at 16:01 -0700, Roland Dreier wrote: > On Tue, Sep 27, 2011 at 1:46 PM, Nicholas A. Bellinger > <nab@xxxxxxxxxxxxxxx> wrote: > > + spin_lock_irqsave(&sess->sess_cmd_lock, flags2); > > + list_del(&cmd->cmd_list); > > + spin_unlock_irqrestore(&sess->sess_cmd_lock, flags2); > > + spin_unlock_irqrestore(&ha->hardware_lock, flags); > > This nesting with flags2 isn't needed. You know IRQs are off so you > don't need anything beyond plain spin_lock/spin_unlock inside > the other spin_lock_irqsave(). > Ah yes, dropping this unnecessary case and two other locations where the same are left-over for qla_tgt_sess->sess_cmd_lock. --nab -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
