Re: [PATCH 2/2] tcm_qla2xxx: Run ->check_stop_free and ->release_cmd with hardware_lock held

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 27, 2011 at 1:46 PM, Nicholas A. Bellinger
<nab@xxxxxxxxxxxxxxx> wrote:
> +       spin_lock_irqsave(&sess->sess_cmd_lock, flags2);
> +       list_del(&cmd->cmd_list);
> +       spin_unlock_irqrestore(&sess->sess_cmd_lock, flags2);
> +       spin_unlock_irqrestore(&ha->hardware_lock, flags);

This nesting with flags2 isn't needed.  You know IRQs are off so you
don't need anything beyond plain spin_lock/spin_unlock inside
the other spin_lock_irqsave().

 - R.
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SCSI]     [Kernel Newbies]     [Linux SCSI Target Infrastructure]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Device Mapper]

  Powered by Linux