Hello, I am just confirming that both sshconfdir=no and sshdconfdir=no options are working as intended now. Thank you for fixing this issue. Best, Daechir Sent with Proton Mail secure email. On Tuesday, January 30th, 2024 at 5:32 AM, František Šumšal <frantisek@xxxxxxxxx> wrote: > On 1/30/24 05:03, daechir wrote: > > > Hello, > > > > Thank you for the quick fix. I am confirming a successful build now with sshconfdir=no. However, I noticed this in the logs: > > > > systemd-tmpfiles[1078]: /usr/lib/tmpfiles.d/20-systemd-ssh-generator.conf:10: Path 'no/20-systemd-ssh-proxy.conf' not absolute. > > > I opened https://github.com/systemd/systemd/pull/31125 that should fix this. > > > And here is a list of files that are leftover when this option is used: > > systemd-git /usr/lib/systemd/system-generators/systemd-ssh-generator > > systemd-git /usr/lib/systemd/systemd-ssh-proxy > > systemd-git /usr/lib/tmpfiles.d/20-systemd-ssh-generator.conf > > systemd-git /usr/share/man/man1/systemd-ssh-proxy.1.gz > > systemd-git /usr/share/man/man8/systemd-ssh-generator.8.gz > > > > I am unsure if keeping all of the above is desired or not. For example, certain server environments may not need it. I shall let you decide. I am learning a lot about how systemd works just based off of these commits. Maybe I can write some patchwork in the future. > > > Except for 20-systemd-ssh-generator.conf (see above) all of these are expected to exist, as the sshconfdir and sshdconfdir options only affect ssh-related config files (and links) we create, they don't disable the helper programs themselves. > > > Thanks again. > > > > Best, > > Daechir > > > > Sent with Proton Mail secure email. > > > > On Tuesday, January 23rd, 2024 at 1:01 PM, emanuele emanuele@xxxxxxxxxxxx wrote: > > > > > Ok > > > > > Il 22/01/24 17:56, František Šumšal ha scritto: > > > > > > On 1/22/24 16:22, daechir wrote: > > > > > > > Hello, > > > > > > > I wanted to do a quick followup on this. I think I may have found > > > > > where the issue lies. > > > > > > > In https://github.com/systemd/systemd/blob/main/meson.build there's: > > > > > > > sshconfdir = get_option('sshconfdir') > > > > > if sshconfdir == '' > > > > > > > But above you shall find: > > > > > > > rpmmacrosdir = get_option('rpmmacrosdir') > > > > > if rpmmacrosdir != 'no' > > > > > > > So perhaps it should be: > > > > > > > sshconfdir = get_option('sshconfdir') > > > > > if sshconfdir != 'no' > > > > > > No, this is correct, we set the path to some default value if it's not > > > > set. However, sshconfdir (and sshdconfidir) is missing the "no" value > > > > check when installing the config symlink. I prepped a fix for that, > > > > would be great if you could give it a try: > > > > https://github.com/systemd/systemd/pull/31047 > > > > > > > This issue may not just effect sshconfdir but all below: > > > > > > > pamconfdir > > > > > sshconfdir > > > > > sshdconfdir > > > > > bashcompletiondir > > > > > zshcompletiondir > > > > > > > Best, > > > > > Daechir > > > > > > > Sent with Proton Mail secure email. > > > > > > > On Monday, January 15th, 2024 at 9:15 AM, daechir > > > > > daechir@xxxxxxxxxxxxxx wrote: > > > > > > > > Hello, > > > > > > There's a build failure with the meson option sshconfdir=no. The > > > > > > error is as follows: > > > > > > > > Running custom install script '/usr/bin/sh -c /usr/bin/ln -frsT -- > > > > > > "${DESTDIR:-}/usr/lib/systemd/ssh_config.d/20-systemd-ssh-proxy.conf" > > > > > > "${DESTDIR:-}no/20-systemd-ssh-proxy.conf"' > > > > > > /usr/bin/ln: failed to create symbolic link > > > > > > '$/systemd-git/pkg/systemd-gitno/20-systemd-ssh-proxy.conf': No such > > > > > > file or directory > > > > > > > > Best, > > > > > > Daechir > > > > > > > > Sent with Proton Mail secure email.
Attachment:
publickey - daechir@protonmail.com - 0x16D272E3.asc
Description: application/pgp-keys
Attachment:
signature.asc
Description: OpenPGP digital signature
