Re: Build failure with sshconfdir=no

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/22/24 16:22, daechir wrote:
Hello,

I wanted to do a quick followup on this. I think I may have found where the issue lies.

In https://github.com/systemd/systemd/blob/main/meson.build there's:

sshconfdir = get_option('sshconfdir')
if sshconfdir == ''

But above you shall find:

rpmmacrosdir = get_option('rpmmacrosdir')
if rpmmacrosdir != 'no'

So perhaps it should be:

sshconfdir = get_option('sshconfdir')
if sshconfdir != 'no'

No, this is correct, we set the path to some default value if it's not set. However, sshconfdir (and sshdconfidir) is missing the "no" value check when installing the config symlink. I prepped a fix for that, would be great if you could give it a try: https://github.com/systemd/systemd/pull/31047

This issue may not just effect sshconfdir but all below:

pamconfdir
sshconfdir
sshdconfdir
bashcompletiondir
zshcompletiondir

Best,
Daechir

Sent with Proton Mail secure email.

On Monday, January 15th, 2024 at 9:15 AM, daechir <daechir@xxxxxxxxxxxxxx> wrote:


Hello,
There's a build failure with the meson option sshconfdir=no. The error is as follows:


Running custom install script '/usr/bin/sh -c /usr/bin/ln -frsT -- "${DESTDIR:-}/usr/lib/systemd/ssh_config.d/20-systemd-ssh-proxy.conf" "${DESTDIR:-}no/20-systemd-ssh-proxy.conf"'
/usr/bin/ln: failed to create symbolic link '$/systemd-git/pkg/systemd-gitno/20-systemd-ssh-proxy.conf': No such file or directory


Best,
Daechir






Sent with Proton Mail secure email.



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux