Re: [PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote:

> > -               kfree_skb(skb);
> > +       INIT_LIST_HEAD(&q->new_flows);
> > +       INIT_LIST_HEAD(&q->old_flows);
> > +       for (i = 0; i < q->flows_cnt; i++) {
> > +               struct fq_codel_flow *flow = q->flows + i;
> > +
> > +               while (flow->head)
> > +                       kfree_skb(dequeue_head(flow));
> > +
> > +               INIT_LIST_HEAD(&flow->flowchain);
> 
> 
> You probably need to call codel_vars_init(&flow->cvars) as well.

It is not necessary : flow->cvars only matter in the event of a dequeue,
but whole qdisc is dismantled and no packet will be dequeued.


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]