On Thu, Apr 16, 2015 at 06:52:56AM +0200, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
>
> On Wed, 15 Apr 2015 12:40:47 +0200, Gregory CLEMENT wrote:
> > There is no crystal connected to the internal RTC on the Open Block
> > AX3. So let's disable it in order to prevent the kernel probing the
> > driver uselessly. Eventually this patches removes the following
> > warning message from the boot log:
> > "rtc-mv d0010300.rtc: internal RTC not ticking"
> >
> > Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
> > Cc: <stable@xxxxxxxxxxxxxxx> # v3.8 +
>
> If an external crystal is needed on the board for the internal RTC,
> then shouldn't instead the RTC have status = "disabled" in the
> SoC-level .dtsi, and each board enabling it in its own
> specific .dts, like we do for all other hardware blocks that
> require/use external components/connexions?
>
> Or, because the AX3 appears to be the only board in this case, we
> decide to factorize enabling the RTC in the .dtsi, and leave it as a
> special case to handle in the AX3 .dts ?
Hi Thomas
Experience from Kirkwood is that the majority of boards use the
internal RTC. Not having a crystal is the exception. So think default
enabled makes sense.
The only side affect of having the RTC enabled when there is no
crystal is the warning message. It makes no difference to the active
RTC on the i2c bus, it becomes rtc0.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html