Re: [PATCH] ARM: mvebu: armada-xp-openblocks-ax3-4: Disable internal RTC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Gregory CLEMENT,

On Wed, 15 Apr 2015 12:40:47 +0200, Gregory CLEMENT wrote:
> There is no crystal connected to the internal RTC on the Open Block
> AX3. So let's disable it in order to prevent the kernel probing the
> driver uselessly. Eventually this patches removes the following
> warning message from the boot log:
> "rtc-mv d0010300.rtc: internal RTC not ticking"
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v3.8 +

If an external crystal is needed on the board for the internal RTC,
then shouldn't instead the RTC have status = "disabled" in the
SoC-level .dtsi, and each board enabling it in its own
specific .dts, like we do for all other hardware blocks that
require/use external components/connexions?

Or, because the AX3 appears to be the only board in this case, we
decide to factorize enabling the RTC in the .dtsi, and leave it as a
special case to handle in the AX3 .dts ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]