This is a note to let you know that I've just added the patch titled
ALSA: control: Add sanity checks for user ctl id name string
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-control-add-sanity-checks-for-user-ctl-id-name-string.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From be3bb8236db2d0fcd705062ae2e2a9d75131222f Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@xxxxxxx>
Date: Wed, 11 Mar 2015 18:12:49 +0100
Subject: ALSA: control: Add sanity checks for user ctl id name string
From: Takashi Iwai <tiwai@xxxxxxx>
commit be3bb8236db2d0fcd705062ae2e2a9d75131222f upstream.
There was no check about the id string of user control elements, so we
accepted even a control element with an empty string, which is
obviously bogus. This patch adds more sanity checks of id strings.
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
sound/core/control.c | 4 ++++
1 file changed, 4 insertions(+)
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -1168,6 +1168,10 @@ static int snd_ctl_elem_add(struct snd_c
if (info->count < 1)
return -EINVAL;
+ if (!*info->id.name)
+ return -EINVAL;
+ if (strnlen(info->id.name, sizeof(info->id.name)) >= sizeof(info->id.name))
+ return -EINVAL;
access = info->access == 0 ? SNDRV_CTL_ELEM_ACCESS_READWRITE :
(info->access & (SNDRV_CTL_ELEM_ACCESS_READWRITE|
SNDRV_CTL_ELEM_ACCESS_INACTIVE|
Patches currently in stable-queue which might be from tiwai@xxxxxxx are
queue-3.14/alsa-hda-set-single_adc_amp-flag-for-cs420x-codecs.patch
queue-3.14/alsa-hda-fix-regression-of-hd-audio-controller-fallback-modes.patch
queue-3.14/alsa-snd-usb-add-quirks-for-roland-ua-22.patch
queue-3.14/alsa-hda-add-workaround-for-macbook-air-5-2-built-in-mic.patch
queue-3.14/alsa-hda-fix-built-in-mic-on-compaq-presario-cq60.patch
queue-3.14/alsa-control-add-sanity-checks-for-user-ctl-id-name-string.patch
queue-3.14/alsa-hda-treat-stereo-to-mono-mix-properly.patch
queue-3.14/alsa-hda-don-t-access-stereo-amps-for-mono-channel-widgets.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html