This is a note to let you know that I've just added the patch titled
Revert "i2c: core: Dispose OF IRQ mapping at client removal time"
to the 3.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-i2c-core-dispose-of-irq-mapping-at-client-removal-time.patch
and it can be found in the queue-3.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From a49445727014216703a3c28ccee4cef36d41571e Mon Sep 17 00:00:00 2001
From: Jakub Kicinski <kubakici@xxxxx>
Date: Wed, 11 Mar 2015 18:35:36 +0100
Subject: Revert "i2c: core: Dispose OF IRQ mapping at client removal time"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Jakub Kicinski <kubakici@xxxxx>
commit a49445727014216703a3c28ccee4cef36d41571e upstream.
This reverts commit e4df3a0b6228
("i2c: core: Dispose OF IRQ mapping at client removal time")
Calling irq_dispose_mapping() will destroy the mapping and disassociate
the IRQ from the IRQ chip to which it belongs. Keeping it is OK, because
existent mappings are reused properly.
Also, this commit breaks drivers using devm* for IRQ management on
OF-based systems because devm* cleanup happens in device code, after
bus's remove() method returns.
Signed-off-by: Jakub Kicinski <kubakici@xxxxx>
Reported-by: Sébastien Szymanski <sebastien.szymanski@xxxxxxxxxxxx>
Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
[wsa: updated the commit message with findings fromt the other bug report]
Signed-off-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
Fixes: e4df3a0b6228
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/i2c/i2c-core.c | 3 ---
1 file changed, 3 deletions(-)
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -679,9 +679,6 @@ static int i2c_device_remove(struct devi
status = driver->remove(client);
}
- if (dev->of_node)
- irq_dispose_mapping(client->irq);
-
dev_pm_domain_detach(&client->dev, true);
return status;
}
Patches currently in stable-queue which might be from kubakici@xxxxx are
queue-3.19/revert-i2c-core-dispose-of-irq-mapping-at-client-removal-time.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html