On 2/24/2015 3:10 PM, Greg KH wrote: > On Tue, Feb 24, 2015 at 02:45:37PM -0800, Danesh Petigara wrote: >> On 2/24/2015 2:22 PM, Greg KH wrote: >>> On Tue, Feb 24, 2015 at 02:17:46PM -0800, Danesh Petigara wrote: >>>> The CMA aligned offset calculation is incorrect for >>>> non-zero order_per_bit values. >>>> >>>> For example, if cma->order_per_bit=1, cma->base_pfn= >>>> 0x2f800000 and align_order=12, the function returns >>>> a value of 0x17c00 instead of 0x400. >>>> >>>> This patch fixes the CMA aligned offset calculation. >>>> >>>> Cc: stable@xxxxxxxxxxxxxxx >>>> Signed-off-by: Danesh Petigara <dpetigara@xxxxxxxxxxxx> >>>> Reviewed-by: Gregory Fong <gregory.0xf0@xxxxxxxxx> >>>> Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx> >>>> --- >>>> Changes since v1: >>>> - moved comment out of function >>>> - removed unused 'alignment' variable >>>> >>>> v1: https://lkml.org/lkml/2015/2/24/598 >>>> >>> >>> <formletter> >>> >>> This is not the correct way to submit patches for inclusion in the >>> stable kernel tree. Please read Documentation/stable_kernel_rules.txt >>> for how to do this properly. >>> >>> </formletter> >>> >> >> Apologize for the lapse. I'm trying to use 'Option 1' >> (Cc: field in patch) to submit the patch to the stable kernel >> but in this case the email got sent out prematurely by mistake. >> I'll be more careful henceforth. Do you prefer that I use option >> 2 or 3? > > The patch has to be in Linus's tree, if it's there, just send the git > commit id and what tree(s) you want it applied to, no need to send the > patch at all, right? > > Unless it needs to be backported, you provided no information here at > all for us to know what is going on with this patch, hence my formletter > response. > The patch isn't in Linus's tree yet. I'm trying to push it upstream. My intention was to send the patch to the mm maintainers with 'Cc: stable@xxxxxxxxxxxxxxx' in the commit for stable to pick up after the patch gets accepted, but the submission went wrong and the e-mail only made it to the stable list (apologies once again). I'll resubmit the patch with all the relevant maintainers included. > thanks, > > greg k-h > Best regards, Danesh -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html