On Thu, Dec 5, 2024 at 4:12 PM Ilya Dryomov <idryomov@xxxxxxxxx> wrote: > Max, would you be willing to redo this patch to pass true for own_pages > and post a v2? There is nothing "bad", "partial" or otherwise wrong > with this version, but having the pages be taken care of automatically > is a bit nicer and a conflict with Alex's ongoing work would be avoided. Yes, I will send a patch for this. Even though I don't agree that this is the best way forward; I'd prefer to fix the leak with a minimal patch adding only the necessary calls, and not mix this with code refactoring. A minimal fix is easier to review. Mixing a bug fix with refactoring is more dangerous, which is important to avoid, because this patch will be put in all stable branches. But ... if you want to, I'll do that. btw. Alex's patch (https://github.com/ceph/ceph-client/commit/2a802a906f9c89f8ae4) introduces another memory leak: by postponing the ceph_osdc_put_request() call, the -EFAULT branch now leaks the ceph_osd_request object. I'll take care not to make the same mistake in my v2.
