I will explain the process for ceph client patches. It's important to note: The process itself and part of the automation is still evolving and so many things have to be done manually. 1. A patch is created and pushed into a local testing branch and tested with xfstests on a kernel compiled with KASAN, several static analysis tools are run as well. 2. The local testing branch is merged with the `testing` branch which implies that all sepia labs teutology tests run on this new kernel -- so care must be taken before pushing. 3. The patch is reviewed on the mailing list by the community, when acked Ilya takes it to the main branch and eventually to the upstream kernel. I will break it up into three separate patches, as it addresses three different issues. So that's a good comment. Any other constructive comments will be appreciated, both regarding the patch and the process. I didn't send an RFC yet; I need to understand how the other two issues were fixed as well, I will send an RFC when I'm done, as I need to make sure all root causes are fixed. I prefer fixing things once. On Thu, Dec 5, 2024 at 2:22 PM Max Kellermann <max.kellermann@xxxxxxxxx> wrote: > > On Thu, Dec 5, 2024 at 1:02 PM Max Kellermann <max.kellermann@xxxxxxxxx> wrote: > > - What "other thread"? I can't find anything on LKML and ceph-devel. > > Just in case you mean this patch authored by you: > https://github.com/ceph/ceph-client/commit/2a802a906f9c89f8ae492dbfcd82ff41272abab1 > > I don't think that's a good patch, and if I had the power, I would > certainly reject it, because: > > - it's big and confusing; hard to review > - it's badly documented; the commit message is just "fixing a race > condition when a file shrinks" but other than that, doesn't explain > anything; a proper explanation is necessary for such a complicated > diff > - the patch changes many distinct things in one patch, but it should > really be split > - this patch is about the buffer overflow for which my patch is much > simpler: https://lore.kernel.org/lkml/20241127212130.2704804-1-max.kellermann@xxxxxxxxx/ > which I suggested merging instead of all the other candicate patches > https://lore.kernel.org/lkml/CAKPOu+9kdcjMf36bF3HAW4K8v0mHxXQX3_oQfGSshmXBKtS43A@xxxxxxxxxxxxxx/ > but you did not reply (as usual, sigh!) > - deeply hidden in this patch is also a fix for the memory leak, but > instead of making one large patch which fixes everything, you should > first merge my trivial leak bug fix and then the fix for the buffer > overflow on top >
