On 02/12/2024 19:43, Naresh Kamboju wrote:
> The arm queues build gcc-12 defconfig-lkftconfig failed on the
> Linux stable-rc queue 5.15 for the arm architectures.
>
> arm
> * arm, build
> - build/gcc-12-defconfig-lkftconfig
>
> Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
>
> Build errors:
> ------
> drivers/clocksource/timer-ti-dm-systimer.c: In function
> 'dmtimer_percpu_quirk_init':
> drivers/clocksource/timer-ti-dm-systimer.c:691:39: error: expected
> '=', ',', ';', 'asm' or '__attribute__' before '__free'
> 691 | struct device_node *arm_timer __free(device_node) =
> | ^~~~~~
> drivers/clocksource/timer-ti-dm-systimer.c:691:39: error: implicit
> declaration of function '__free'; did you mean 'kfree'?
> [-Werror=implicit-function-declaration]
> 691 | struct device_node *arm_timer __free(device_node) =
> | ^~~~~~
> | kfree
> drivers/clocksource/timer-ti-dm-systimer.c:691:46: error:
> 'device_node' undeclared (first use in this function)
> 691 | struct device_node *arm_timer __free(device_node) =
> | ^~~~~~~~~~~
> drivers/clocksource/timer-ti-dm-systimer.c:691:46: note: each
> undeclared identifier is reported only once for each function it
> appears in
> drivers/clocksource/timer-ti-dm-systimer.c:694:36: error: 'arm_timer'
> undeclared (first use in this function); did you mean 'add_timer'?
> 694 | if (of_device_is_available(arm_timer)) {
> | ^~~~~~~~~
> | add_timer
> cc1: some warnings being treated as errors
>
The __free() macro is defined in include/linux/cleanup.h, and that
header does not exist in v5.15. It was introduced with v6.1, and older
kernels can't profit from it.
That means that this patch does not apply in its current form for v5.15.
If someone wants to backport it, calls to of_node_put() have to be added
to the early returns.
Best regards,
Javier Carrasco
