On Mon, 21 Oct 2024 10:19:53 +0200, Kailang wrote: > > Change to below model. > + SND_PCI_QUIRK(0x17aa, 0x231e, "Thinkpad", ALC287_FIXUP_THINKPAD_I2S_SPK), > + SND_PCI_QUIRK(0x17aa, 0x231f, "Thinkpad", ALC287_FIXUP_THINKPAD_I2S_SPK), > > The speaker will have output. Right? FWIW, that was what I asked in https://lore.kernel.org/87h697jl6c.wl-tiwai@xxxxxxx and Dean replied that the speaker worked with it. (His reply missed Cc, so it didn't appear in the thread, unfortunately). Takashi > > -----Original Message----- > > From: Takashi Iwai <tiwai@xxxxxxx> > > Sent: Monday, October 21, 2024 2:59 PM > > To: Dean Matthew Menezes <dean.menezes@xxxxxxxxxx> > > Cc: Takashi Iwai <tiwai@xxxxxxx>; Kailang <kailang@xxxxxxxxxxx>; > > stable@xxxxxxxxxxxxxxx; regressions@xxxxxxxxxxxxxxx; Jaroslav Kysela > > <perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Linux Sound System > > <linux-sound@xxxxxxxxxxxxxxx>; Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > > Subject: Re: No sound on speakers X1 Carbon Gen 12 > > > > > > External mail. > > > > > > > > On Mon, 21 Oct 2024 03:30:13 +0200, > > Dean Matthew Menezes wrote: > > > > > > I can confirm that the original fix does not bring back the speaker > > > output. I have attached both outputs for alsa-info.sh > > > > Thanks! This confirms that the only significant difference is the COEF data > > between working and patched-non-working cases. > > > > Kailang, I guess this model (X1 Carbon Gen 12) isn't with ALC1318, hence your > > quirk rather influences badly. Or may the GPIO3 workaround have the similar > > effect? > > > > As of now, the possible fix is to simply remove the quirk entries for ALC1318. > > But I'd need to know which model was targeted for your original fix in commit > > 1e707769df07 and whether the regressed model is with ALC1318. > > > > > > Takashi
