Re: [PATCH 5.10.y 0/4] Backport fix commit for kprobe_non_uniq_symbol.tc test failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Oct 9, 2024, at 6:36 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> On Tue, Oct 08, 2024 at 03:29:44PM -0700, Sherry Yang wrote:
>> 5.10.y backported the commit 
>> 09bcf9254838 ("selftests/ftrace: Add new test case which checks non unique symbol")
>> which added a new test case to check non-unique symbol. However, 5.10.y
>> didn't backport the kernel commit 
>> b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func matches several symbols")to support the functionality from kernel side. Backport it in this patch series.
>> 
>> The first two patches are presiquisites. The 4th commit is a fix commit
>> for the 3rd one.
> 
> Should we just revert the selftest test instead?  That seems simpler
> instead of adding a new feature to this old and obsolete kernel tree,
> right?

Sorry about the confusion. If kprobe attaches a function which is not the user wants to attach to, I would say it’s a bug. The test case uncovers the bug, so it’s a fix.

Sherry






[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux