On Wed, Oct 02, 2024 at 10:12:32AM -0400, Youzhong Yang wrote: > My understanding is that the following 4 commits together fix the leaking issue: > > nfsd: add list_head nf_gc to struct nfsd_file > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8e6e2ffa6569a205f1805cbaeca143b556581da6 > > nfsd: fix refcount leak when file is unhashed after being found > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8a7926176378460e0d91e02b03f0ff20a8709a60 > > nfsd: remove unneeded EEXIST error check in nfsd_do_file_acquire > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=81a95c2b1d605743220f28db04b8da13a65c4059 > > nfsd: count nfsd_file allocations > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=700bb4ff912f954345286e065ff145753a1d5bbe > > The first two are essential but it's better to have the last two commits too. So right now only the 2nd and 3rd are in the tree, do we really need the others as well? And if so, why were none of these marked for a stable inclusion? Can they wait for the next round of releases? thanks, greg k-h